Fix width of strong typed integers#751
Closed
wvpm wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Shelved for now due to IndexedFlatMap issues and other PRs editing that type... |
Member
|
I would suggest that it be best to simply be explicit with the godot bindings and not be clever with them, the only case where this turns into an issue despite that is assigning a size_to to a dictionary, which could be a justification but we should really not be relying on dictionaries being passed to godot anyway, its only being left around to avoid refactoring it twice as consequence of the potential ECS refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of our indices fit within uint16_t. We want to avoid size_t as it is platform dependent and causes issues for macos in godot.